-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for converting notebooks that contain unicode characters. #3870
Conversation
We'll need to check whether Also, it would be slightly neater to use |
@takluyver - thanks, I'll give those suggestions a try |
output should always be unicode |
Go ahead make make the |
@astrofrog want to make that change? |
Fix for converting notebooks that contain unicode characters.
specify encoding in nbconvert io.open call (finishes #3870).
Merged here and applied finishing touches in #3879. |
@minrk - thanks for finishing this up, I was traveling today and didn't get a chance to do this sooner. |
No problem - sorry for my impatience, just getting ready to cut the release candidate. |
Fix for converting notebooks that contain unicode characters.
specify encoding in nbconvert io.open call (finishes ipython#3870).
I tried converting a notebook that had a ü in it using nbconvert, and get:
The attached code seems to fix this, but understanding the intricacies of unicode isn't my strongest point, so let me know if it's the completely wrong approach :)