Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't force . relative path, fix #3897 #3901

Merged
merged 1 commit into from Aug 5, 2013
Merged

Conversation

ivanov
Copy link
Member

@ivanov ivanov commented Aug 5, 2013

As per #3897, .\filename is not recognized by pdflatex.

As per ipython#3897, .\filename is not recognized by pdflatex.
@ivanov
Copy link
Member Author

ivanov commented Aug 5, 2013

I should note that there were several places in the code which were previously triggered when they probably did not need to be, because they were testing if self.build_directory: which was previously always set to something (i.e. `'.'``)

@ivanov
Copy link
Member Author

ivanov commented Aug 5, 2013

user reporting #3897 confirmed this fixes the issue, ready to merge, 👍 me!

@jdfreder
Copy link
Member

jdfreder commented Aug 5, 2013

👍

jdfreder added a commit that referenced this pull request Aug 5, 2013
don't force . relative path, fix #3897
@jdfreder jdfreder merged commit a883828 into ipython:master Aug 5, 2013
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants