Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook docs touchup #3902

Closed
wants to merge 11 commits into from
Closed

Conversation

dpsanders
Copy link
Contributor

Cleaning up outstanding issues in notebook.rst.

@@ -563,7 +552,7 @@ on available options, use::
:ref:`config_overview`, in particular :ref:`Profiles`.


Importing `.py` files
Importing ``.py` files
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mismatched quote.

@@ -98,20 +98,24 @@ and rich representations of objects.

Notebooks may easily be exported to a range of static formats, including
HTML (for example, for blog posts), PDF and slide shows,
via the new nbconvert_ command.
via the new ``nbconvert`_ command.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missmatch backticks ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

There is a problem in nbconvert.rst in line 70, where it refers to "three
backticks",
but these are not rendered correctly in the final HTML.
I tried to fix it, but without success. Any ideas?

On Mon, Aug 5, 2013 at 7:07 AM, Matthias Bussonnier <
notifications@github.com> wrote:

In docs/source/interactive/notebook.rst:

@@ -98,20 +98,24 @@ and rich representations of objects.

Notebooks may easily be exported to a range of static formats, including
HTML (for example, for blog posts), PDF and slide shows,
-via the new nbconvert_ command.
+via the new ``nbconvert`_ command.

missmatch backticks ?


Reply to this email directly or view it on GitHubhttps://github.com//pull/3902/files#r5577151
.

Dr. David P. Sanders

Profesor Titular "A" / Associate Professor
Departamento de Física, Facultad de Ciencias
Universidad Nacional Autónoma de México (UNAM)

dpsanders@gmail.com
http://sistemas.fciencias.unam.mx/~dsanders

Cubículo / office: #414, 4o. piso del Depto. de Física

Tel.: +52 55 5622 4965

@Carreau
Copy link
Member

Carreau commented Aug 5, 2013

Maybe one small comment. Otherwise looks great.

@Carreau
Copy link
Member

Carreau commented Aug 5, 2013

Did you fixed the backticks ? you can make some live experiments here if needed.

@dpsanders
Copy link
Contributor Author

Got it, thanks!

On Mon, Aug 5, 2013 at 7:38 AM, Matthias Bussonnier <
notifications@github.com> wrote:

Did you fixed the backticks ? you can make some live experiments herehttp://rst.ninjs.org/?n=9762a58691da2557322279d85759362b&theme=natureif needed.


Reply to this email directly or view it on GitHubhttps://github.com//pull/3902#issuecomment-22103308
.

Dr. David P. Sanders

Profesor Titular "A" / Associate Professor
Departamento de Física, Facultad de Ciencias
Universidad Nacional Autónoma de México (UNAM)

dpsanders@gmail.com
http://sistemas.fciencias.unam.mx/~dsanders

Cubículo / office: #414, 4o. piso del Depto. de Física

Tel.: +52 55 5622 4965

``Ctrl-m i`` interrupt kernel
``Ctrl-m .`` restart kernel
``Ctrl-m h`` show keyboard shortcuts
=============== ==========================
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

undo this change, monospace is not helpful here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore me - it's better to be consistent, and monospace is the way keyboard shortcuts are done elsehwere. But it is best to use :kbd:Ctrl-m h`` for uniform formatting, rather than plain ````

@dpsanders
Copy link
Contributor Author

I just moved the "roundtrip" warning to the end, in the section on importing .py.

All comments now addressed; ready to merge.

@jdfreder
Copy link
Member

jdfreder commented Aug 6, 2013

This looks good @dpsanders ! Thanks for all the help 👍

a literate way, interleaving executable code with rich text, mathematics,
and rich representations of objects.
Notebook document files are simple JSON_ files with the extension ``.ipynb``.
Since JSON is just plain text, they can be easily version-controlled and
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easy version-controlled? I don't think so... ;-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@damianavila Please explain? Because of the figures you mean?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean that the you can not easily version-control the .ipynb files... you have to pre-process them to do it... for example, every time you run a cell, the input and output numbers change, so you can get the same notebook, I mean with the same content, but with differences between them... then, you have changes to commit that makes no sense... I hope to be enough clear... ;-)

@Carreau
Copy link
Member

Carreau commented Aug 6, 2013

Do you want to add a warning that running over http/without password is dangerous even on localhost if machine has multiple user accounts ?

@@ -58,7 +63,7 @@ the command::
Your browser will warn you of a dangerous certificate because it is
self-signed. If you want to have a fully compliant certificate that will not
raise warnings, it is possible (but rather involved) to obtain one,
`as explained in detailed in this tutorial`__.
as explained in detailed in `this tutorial`__.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes like these are not necessary

@ivanov
Copy link
Member

ivanov commented Aug 6, 2013

I fear that this is hardly a "touch up" of the docs anymore. @dpsanders can you squash these commits? it's getting quite a bit unruly. Please do not inlcude the non-functional changes (e.g. keep the htmlnotebook anchor as it was, or the link name change in working_remotely.rst)

@dpsanders
Copy link
Contributor Author

Sure, please suggest the text to add and where to add it!

On Tue, Aug 6, 2013 at 2:12 AM, Matthias Bussonnier <
notifications@github.com> wrote:

Do you want to add a warning that running over http/without password is
dangerous even on localhost if machine has multiple user accounts ?


Reply to this email directly or view it on GitHubhttps://github.com//pull/3902#issuecomment-22162226
.

Dr. David P. Sanders

Profesor Titular "A" / Associate Professor
Departamento de Física, Facultad de Ciencias
Universidad Nacional Autónoma de México (UNAM)

dpsanders@gmail.com
http://sistemas.fciencias.unam.mx/~dsanders

Cubículo / office: #414, 4o. piso del Depto. de Física

Tel.: +52 55 5622 4965

@dpsanders
Copy link
Contributor Author

@ivanov OK, I see what you mean. How do I "squash these commits"?
(Though the link change in working_remotely.rst is the definition of "touchup" in my book!)

@Carreau
Copy link
Member

Carreau commented Aug 6, 2013

in the security section, change you can by you should. And something along "even if you use the IPython Notebook on a local machine, launching it without authentification can allow any other user or program of this machine to connect to IPython and run arbitrary command on your behalf. This is why we strongly advise to use password protected notebook over https"

@Carreau
Copy link
Member

Carreau commented Aug 6, 2013

As for squashing you should read that

@ivanov
Copy link
Member

ivanov commented Aug 7, 2013

I've squashed an cherry-picked the functional changes in a local branch and will have a PR shortly that will close this one

@dpsanders
Copy link
Contributor Author

@ivanov Many thanks -- classes started again on Monday, and I have not had the time or mental energy to sit down and work out how to do this. Python-ing time will now be severely curtailed... but I'm planning to base my teaching around the IPython notebook, so you can expect bug reports and user interface complaints...
Hope to get some students involved too...

@ivanov ivanov mentioned this pull request Aug 8, 2013
@ivanov ivanov closed this in 9f3e416 Aug 9, 2013
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
closes ipython#3902

incorporating doc changes from David Sanders, minor revisions my own

-@ivanov
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants