Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't make sphinx a dependency for importing nbconvert #3960

Merged
merged 1 commit into from
Aug 10, 2013

Conversation

minrk
Copy link
Member

@minrk minrk commented Aug 8, 2013

Just move the import so it doesn't fire unless sphinx is used.

Even though it's trivial, probably not for 1.0.

@damianavila
Copy link
Member

I agree... it was to wide...

@jdfreder
Copy link
Member

jdfreder commented Aug 8, 2013

Makes sense to me, you may need to remove it as a dependency from iptest too (not sure about this, I haven't looked myself)

@jdfreder
Copy link
Member

jdfreder commented Aug 9, 2013

👍 now that we are on 2.0dev

jdfreder added a commit that referenced this pull request Aug 10, 2013
Don't make sphinx a dependency for importing nbconvert
@jdfreder jdfreder merged commit ac2aab8 into ipython:master Aug 10, 2013
minrk added a commit that referenced this pull request Aug 10, 2013
…vert

Just move the import so it doesn't fire unless sphinx is used.

Even though it's trivial, probably not for 1.0.
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
Don't make sphinx a dependency for importing nbconvert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants