-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Python 2.6 and 3.2 #4002
Drop Python 2.6 and 3.2 #4002
Conversation
That looks good. |
Yay! This all looks great. I'm sure we'll discover more 2.6-isms as we clean up the code, but those can be for later pull requests. |
In what way does this drop 3.2 support? Is this about the |
Yes we'll drop 3.2 because of u'' . This pr "drop" 3.2 support because it deactivate Travis test on 3.2 and remove 3.2 from docs. Envoyé de mon iPhone Le 14 août 2013 à 14:42, Benedikt Sauer notifications@github.com a écrit :
|
As Matthias says: this only removes 3.2 from docs and tests. In a later PR, I'll change things to use the Any objections to me merging this? Does anyone else want to offer an opinion on the irunner bit that Brad brought up? |
I'm planning to merge this later today unless anyone objects. |
No objection here. |
No objection to break master for me. |
Nobody uses Python 2.6 with IPython master - we would have heard about the logging issue if that were the case. |
Read through, and looks great to me. |
OK, in it goes. |
Hey, with |
As the PR describes, IPython 2.0 does not support Python 2.6. If you are on 2.6, you must stick with IPython 1.x. |
Drop Python 2.6 and 3.2
Dropping support for these older versions simplifies various corners of our code, and paves the way for a single codebase that runs on 2.7 and 3.3 (but that will be a separate PR).