Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 2.6 and 3.2 #4002

Merged
merged 8 commits into from
Aug 15, 2013
Merged

Drop Python 2.6 and 3.2 #4002

merged 8 commits into from
Aug 15, 2013

Conversation

takluyver
Copy link
Member

Dropping support for these older versions simplifies various corners of our code, and paves the way for a single codebase that runs on 2.7 and 3.3 (but that will be a separate PR).

@Carreau
Copy link
Member

Carreau commented Aug 13, 2013

That looks good.

@bfroehle
Copy link
Contributor

Yay! This all looks great. I'm sure we'll discover more 2.6-isms as we clean up the code, but those can be for later pull requests.

@filmor
Copy link
Contributor

filmor commented Aug 14, 2013

In what way does this drop 3.2 support? Is this about the u""-syntax?

@Carreau
Copy link
Member

Carreau commented Aug 14, 2013

Yes we'll drop 3.2 because of u'' . This pr "drop" 3.2 support because it deactivate Travis test on 3.2 and remove 3.2 from docs.

Envoyé de mon iPhone

Le 14 août 2013 à 14:42, Benedikt Sauer notifications@github.com a écrit :

In what way does this drop 3.2 support? Is this about the u""-syntax?


Reply to this email directly or view it on GitHub.

@takluyver
Copy link
Member Author

As Matthias says: this only removes 3.2 from docs and tests. In a later PR, I'll change things to use the u'' syntax without 2to3, at which point it will stop working on 3.2.

Any objections to me merging this? Does anyone else want to offer an opinion on the irunner bit that Brad brought up?

@takluyver
Copy link
Member Author

I'm planning to merge this later today unless anyone objects.

@bfroehle
Copy link
Contributor

No objection here.

@Carreau
Copy link
Member

Carreau commented Aug 15, 2013

No objection to break master for me.
Annonce on Ipyton-dev first to warn people still on 2.6 and master (does that exists ?) not to pull ?

@minrk
Copy link
Member

minrk commented Aug 15, 2013

Nobody uses Python 2.6 with IPython master - we would have heard about the logging issue if that were the case.

@minrk
Copy link
Member

minrk commented Aug 15, 2013

Read through, and looks great to me.

@takluyver
Copy link
Member Author

OK, in it goes.

takluyver added a commit that referenced this pull request Aug 15, 2013
@takluyver takluyver merged commit ed74e93 into ipython:master Aug 15, 2013
@esc
Copy link
Contributor

esc commented Apr 2, 2014

Hey, with 2.0.0 this PR broke various integrations tests on our platform today. We use RHEL 6 and Scientific Linux 6.5 (IIRC) and apparently there is no 2.7 package available.

@minrk
Copy link
Member

minrk commented Apr 2, 2014

As the PR describes, IPython 2.0 does not support Python 2.6. If you are on 2.6, you must stick with IPython 1.x.

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants