Test no incorrect 'data:image/png;base64,b' in html files. #4036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it going to be an easy fix? I'd rather merge test+fix than a knownfailure test. ;-) |
|
I confirm it solves the issue in python3. |
|
PR #4043 should actually fix the issue - needs further and careful testing, but it appears this was a bug in nbformat. |
|
Confirmed that it fails with Python 3 and gives correct result on Python 2. |
minrk
added a commit
to minrk/ipython
that referenced
this pull request
Sep 3, 2013
it makes no sense to turn base64-encoded unicode strings into base64-encoded byte strings. I can't think why we do this, but we should be very careful about testing before merging this fix. fixes the issue tested in ipython#4036.
minrk
added a commit
that referenced
this pull request
Sep 9, 2013
It makes no sense to turn base64-encoded unicode strings into base64-encoded byte strings. I can't think why we do this, but we should be very careful about testing before merging this fix. fixes the issue tested in #4036.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
it makes no sense to turn base64-encoded unicode strings into base64-encoded byte strings. I can't think why we do this, but we should be very careful about testing before merging this fix. fixes the issue tested in ipython#4036.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
don't 'restore_bytes' in from_JSON It makes no sense to coerce base64-encoded unicode strings into base64-encoded byte strings. closes ipython#4036
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check that HTML conversion of a notebook with images by "nbconvert --to html" is ok.
It currently fails under python3 (detected in issue #3903 )
bad transformation =
img src="data:image/png;base64,b'iVBOR....
good transformation =
img src="data:image/png;base64,iVBOR....