close Client sockets if connection fails #4074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allows setting `linger` on sockets at shutdown time.
avoids runaway FDs in cases of frequent client failure.
|
|
||
| try: | ||
| self._connect(sshserver, ssh_kwargs, timeout) | ||
| except: |
There was a problem hiding this comment.
Why don't you just use finally?
There was a problem hiding this comment.
Because it shouldn't happen if an exception isn't raised.
|
The error |
minrk
added a commit
that referenced
this pull request
Sep 3, 2013
close Client sockets if connection fails also cleanup Client.close a little bit, allowing setting linger on sockets at shutdown time, which is helpful for preventing FD growth on connection failure. Should be considered for backport to 1.1.
minrk
added a commit
that referenced
this pull request
Sep 4, 2013
avoids runaway FDs in cases of frequent client failure. also cleanup Client.close a little bit, allowing setting `linger` on sockets at shutdown time, which is helpful for preventing FD growth on connection failure. Should be considered for backport to 1.1.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
close Client sockets if connection fails also cleanup Client.close a little bit, allowing setting linger on sockets at shutdown time, which is helpful for preventing FD growth on connection failure. Should be considered for backport to 1.1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avoids runaway FDs in cases of frequent client failure.
also cleanup Client.close a little bit, allowing setting
lingeron sockets at shutdown time,which is helpful for preventing FD growth on connection failure.
Should be considered for backport to 1.1.