Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to support parametric tests #4150

Closed
wants to merge 3 commits into from

Conversation

takluyver
Copy link
Member

Our parametric tests weren't running on either Python 2 or 3, for different reasons. This fixes both issues, so some test failures may appear as we exercise code that hasn't been tested recently.

For Python 2, this works around nose-devs/nose#728, which I just filed. On Python 3, I think the parametric testing machinery has always been broken. The fix is horrendously ugly, but seems to do the trick.

I am about to propose getting rid of our parametric test system, as it has failed too often and too quietly.

Upcoming IPEP will propose that this whole mechanism DIE WITH FIRE, but
at least it's working for now.
@takluyver
Copy link
Member Author

This supersedes #4148

@takluyver
Copy link
Member Author

Test results for commit 5780357 merged into master (6eb7d86)
Platform: linux2

Extra args: ['--all']
Not available for testing:

@takluyver
Copy link
Member Author

The failure on Python 2 looks like a timeout, but there's one genuine failure on Python 3 that was being masked. We should fix that in a separate PR, though.

@ivanov
Copy link
Member

ivanov commented Sep 3, 2013

hey Thomas, is the elimination of parametric tests going to become a part of this branch, or separately?

@takluyver
Copy link
Member Author

No, it will be separate. Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants