Fixes to support parametric tests #4150
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our parametric tests weren't running on either Python 2 or 3, for different reasons. This fixes both issues, so some test failures may appear as we exercise code that hasn't been tested recently.
For Python 2, this works around nose-devs/nose#728, which I just filed. On Python 3, I think the parametric testing machinery has always been broken. The fix is horrendously ugly, but seems to do the trick.
I am about to propose getting rid of our parametric test system, as it has failed too often and too quietly.