Remove use of parametric tests #4165
Conversation
| v = self.client.load_balanced_view() | ||
| yield self.assertEqual(len(v), len(self.client.ids)) | ||
| self.assertEqual(len(v), len(self.client.ids)) | ||
| # parametric tests seem to require manual closing? | ||
| self.client.close() |
There was a problem hiding this comment.
remove this extra close and comment. This was a workaround for parametric tests and causes an error now due to double-closing sockets.
|
Test results for commit fe93e70 merged into master (9f92804)
Extra args: ['--all'] |
|
Do you want to fix the revealed Python3 failures here, or save that for another PR? |
|
Those failures on 3.3 are genuine, from tests that hadn't been running. I'll have a go at fixing them in a separate PR. |
|
I'll merge this tomorrow if there are no objections. |
previously, if from IPython.external.mathjax import * was called, it would cause an error, since the dest variable was renamed to default_dest
|
works for me, tested and confirmed everything seems to be working here. |
|
sent you this PR, Thomas, just removes some now unused imports, fixes a minor issue with IPython.external.mathjax code |
remove unused imports
|
Thanks Paul, I've merged that. We'll merge this later today unless anyone objects. |
|
👍 |
Remove use of parametric tests As discussed on the mailing list, our parametric tests system has been the source of various problems, and we've decided to get rid of it.
Fixes the failing tests revealed by #4165.
Remove use of parametric tests As discussed on the mailing list, our parametric tests system has been the source of various problems, and we've decided to get rid of it.
Fixes the failing tests revealed by ipython#4165.
As discussed on the mailing list, our parametric tests system has been the source of various problems, and we've decided to get rid of it. This implements that, superseding #4150 and #4148.