display: scope SVG's style elements so they do not leak #4236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When multiple SVG figures are inlined in the same dom, they share the same css namespace. This patch, scopes each SVG's style CSS rules so they do not leak into other figures. Should help fixing ipython#1866
This was referenced Sep 19, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple SVG figures are inlined in the same DOM, they
share the same css namespace. This patch, scopes each SVG's style
block so it does not leak into other figures.
Should help fixing #1866
Please see #1866 for the discussion.
(This pull request needs an accompanying patch on ipython-components: jupyter/ipython-components#8)