Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

outputarea.js: Wrap inline SVGs inside an iframe #4250

Merged
merged 10 commits into from
Nov 11, 2013
Merged

outputarea.js: Wrap inline SVGs inside an iframe #4250

merged 10 commits into from
Nov 11, 2013

Commits on Oct 29, 2013

  1. outputarea.js: Wrap inline SVGs inside an iframe 

    When multiple inline SVGs are included in a single document,
they share the same parse tree. Therefore, style collisions and
use id collisions can occur and upset the rendering.

This patch wraps each SVG inside an individual iframe, ensuring
that SVG's declarations do not collide.

(The SVG representation is kept as XML and not converted to a binary
format, so I do not think this approach precludes the use of d3.js)

Tested on:
* Chrome Version 29.0.1547.57 Debian 7.1 (217859)
* Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130806 Firefox/17.0 Iceweasel/17.0.8

Closes ipython#1866
    @pablooliveira
    pablooliveira committed Oct 29, 2013
    Configuration menu
    Copy the full SHA
    333abbe View commit details
    Browse the repository at this point in the history

  2. SVG scoping must be explicitly enabled by the user 

    SVG scoping is disabled by default, to enable it the user
must call the core.display.SVG constructor with the scoped=True
keyword parameter.
    @pablooliveira
    pablooliveira committed Oct 29, 2013
    Configuration menu
    Copy the full SHA
    9519db2 View commit details
    Browse the repository at this point in the history

  3. Fix style and typo

    @pablooliveira
    pablooliveira committed Oct 29, 2013
    Configuration menu
    Copy the full SHA
    c7347ac View commit details
    Browse the repository at this point in the history

  4. SVG: scoped is passed as metadata 

    Instead of using a svg class to pass scope information
use notebook metadata.

Suggested by Matthias Bussonnier
    @pablooliveira
    pablooliveira committed Oct 29, 2013
    Configuration menu
    Copy the full SHA
    358a5d8 View commit details
    Browse the repository at this point in the history

  5. Support isolated metadata tag for any content 

    Any content whose metadata contains an `isolated` tag will be isolated
from the rest of the document.

The current implementation wraps isolated content into an iframe.
    @pablooliveira
    pablooliveira committed Oct 29, 2013
    Configuration menu
    Copy the full SHA
    3cb3116 View commit details
    Browse the repository at this point in the history

  6. Notebook isolated content: fix firefox extra-space issue 

    In Firefox, if the iframe initial height is set to 0, the reported
scrollHeight is too large. Workaround: set the initial height to 1.
    @pablooliveira
    pablooliveira committed Oct 29, 2013
    Configuration menu
    Copy the full SHA
    115dfdc View commit details
    Browse the repository at this point in the history

  7. Add casperjs test for isolated SVGs

    @pablooliveira
    pablooliveira committed Oct 29, 2013
    Configuration menu
    Copy the full SHA
    6d22977 View commit details
    Browse the repository at this point in the history

  8. Fix typo.

    @pablooliveira
    pablooliveira committed Oct 29, 2013
    Configuration menu
    Copy the full SHA
    b6d5922 View commit details
    Browse the repository at this point in the history

  9. Preserve layout for large isolated objects

    @pablooliveira
    pablooliveira committed Oct 29, 2013
    Configuration menu
    Copy the full SHA
    21f1b06 View commit details
    Browse the repository at this point in the history

  10. Set both height and width using css

    @pablooliveira
    pablooliveira committed Oct 29, 2013
    Configuration menu
    Copy the full SHA
    3800774 View commit details
    Browse the repository at this point in the history