Fix scrolling output (not working post clear_output changes) #4289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by adding a conditional for the append output height reset.
| // Only reset the height to automatic if the height is currently | ||
| // fixed (done by wait=True flag on clear_output). | ||
| if (needs_height_reset) { | ||
| this.element.height('auto'); |
There was a problem hiding this comment.
cannot you just remove the height value and leave it blank ? this.element.css("height",""); ?
There was a problem hiding this comment.
Yeah, I think you are right, that should work. I'll test it first just in case.
|
@Carreau comment addressed and changes tested. |
|
great, thanks. Merging. |
Carreau
added a commit
that referenced
this pull request
Oct 4, 2013
Fix scrolling output (not working post clear_output changes) Regression introduced in #4229
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Fix scrolling output (not working post clear_output changes) Regression introduced in ipython#4229
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a conditional for the append output height reset.
Regression introduced in #4229