Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the strip_math_space filter aware of html tags #4310

Closed
wants to merge 1 commit into from

Conversation

jakobgager
Copy link
Contributor

This fixes #4309

The old strip_math_space filter crops some output if no closing $ is found or if less than 2 line breaks are found after the starting $.

Moreover now only spaces and not newlines are stripped.

@minrk
Copy link
Member

minrk commented Sep 30, 2013

I don't think strip_math_space should exist - PR #4313 just removes it outright.

@jakobgager
Copy link
Contributor Author

I'm totally fine with this! Closing!

@jakobgager jakobgager closed this Sep 30, 2013
minrk added a commit to minrk/ipython that referenced this pull request Oct 2, 2013
I don't think it solves any problems with supported pandoc versions,
and it does introduce new ones.

closes ipython#4309
supersedes ipython#4310
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
I don't think it solves any problems with supported pandoc versions,
and it does introduce new ones.

closes ipython#4309
supersedes ipython#4310
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in nbconvert - closing </code> tag is not inserted in HTML under some circumstances
2 participants