remove strip_math_space #4313
remove strip_math_space #4313
Conversation
|
Maybe it would be nice to state what version(s) of Pandoc we support here |
|
But... Does Pandoc reconize math with spaces (or support the remove of them)? There is people writing math with spaces around it, because the notebook support the render of the math in this form... |
It didn't in the earlier versions, but we only support 1.10 and later, and it seems to work with the later. |
|
@jdfreder in #3503 (comment) you mentioned the strip_math_space filter to be used in combination with the extended md2latex approach. Is this still required here? |
No, in the comment above I pasted the
I wasn't using 1.10+ (looks like compiling Pandoc from source and installing it didn't override the install that already existed on my machine) |
|
I'm +1 with removing and would suggest to not backport this, then 1.x.0 can be used with pandoc < 1.10 (and python < 2.7). |
+1 |
| # Generate Pygments definitions for Latex | ||
| from pygments.formatters import LatexFormatter | ||
|
|
||
| resources["latex"].setdefault({}) |
There was a problem hiding this comment.
resources["latex"].setdefault({})
AttributeError: 'str' object has no attribute 'setdefault'
There was a problem hiding this comment.
Don't know how I did that, it's not remotely the right syntax. Fixed now.
I don't think it solves any problems with supported pandoc versions, and it does introduce new ones. closes ipython#4309 supersedes ipython#4310
|
+1 |
|
Merging. Thanks. |
remove strip_math_space, not usefull anymore with recent version of pandoc.
remove strip_math_space, not usefull anymore with recent version of pandoc.
I don't think it solves any problems with supported pandoc versions, and it does introduce new ones.
Unless someone can come up with a case where it actually solves a problem, it should be removed.
closes #4309
supersedes #4310