-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Call PDF viewer after latex compiling (nbconvert) #4348
Conversation
Btw. it seems the configurables of the pdf postprocessor are not registered in the help system, i.e. --help-all does not list the respective options. |
@@ -44,6 +45,9 @@ class PDFPostProcessor(PostProcessorBase): | |||
config=True, help=""" | |||
Filename extensions of temp files to remove after running. | |||
""") | |||
pdf_open = Bool(True, config=True, help=""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
default should probbaly be False
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To represent the original behavior yes, but somehow I'm more inclined to directly open the pdf.
But I will change it to False.
I've only tested with Ubuntu, so maybe a windows and mac user should test this. |
add |
* move file extension addition outside of function * move log statement before function call * change default to False * add postprocessor to nbconvertapp
LGTM. |
+1 to me (but only tested on linux)... |
Call PDF viewer after latex compiling (nbconvert) Add a configurable to open the pdf after compiling. Uses the default application. closes #4291
Thanks! |
Call PDF viewer after latex compiling (nbconvert) Add a configurable to open the pdf after compiling. Uses the default application. closes ipython#4291
Add a configurable to open the pdf after compiling.
Uses the default application.
adresses #4291