Call PDF viewer after latex compiling (nbconvert) #4348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Btw. it seems the configurables of the pdf postprocessor are not registered in the help system, i.e. --help-all does not list the respective options. |
| @@ -44,6 +45,9 @@ class PDFPostProcessor(PostProcessorBase): | |||
| config=True, help=""" | |||
| Filename extensions of temp files to remove after running. | |||
| """) | |||
| pdf_open = Bool(True, config=True, help=""" | |||
There was a problem hiding this comment.
To represent the original behavior yes, but somehow I'm more inclined to directly open the pdf.
But I will change it to False.
|
I've only tested with Ubuntu, so maybe a windows and mac user should test this. |
add |
* move file extension addition outside of function * move log statement before function call * change default to False * add postprocessor to nbconvertapp
|
LGTM. |
|
+1 to me (but only tested on linux)... |
minrk
added a commit
that referenced
this pull request
Oct 6, 2013
Call PDF viewer after latex compiling (nbconvert) Add a configurable to open the pdf after compiling. Uses the default application. closes #4291
|
Thanks! |
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Call PDF viewer after latex compiling (nbconvert) Add a configurable to open the pdf after compiling. Uses the default application. closes ipython#4291
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a configurable to open the pdf after compiling.
Uses the default application.
adresses #4291