Use safe_hasattr in dir2 #4382
Merged
Use safe_hasattr in dir2 #4382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Happy to slim down if you want. |
| except: | ||
| return False | ||
|
|
||
| hasattr = safe_hasattr |
There was a problem hiding this comment.
We should call safe_hasattr, not alias hasattr to it, for clarity.
Add test cases Move safe_hasattr to utils/dir2
|
Need release notes? Different commit message? |
|
@takluyver just tell me if you want me to make any changes and I'll be happy to do so. |
|
Sorry, I just hadn't looked at it over the weekend. No, no need for release notes for a bugfix like this - we autogenerate a list of closed issues and PRs for each release. I'll merge this now. Thanks. |
|
totally fine with me - I was in no rush. Glad I could be helpful! |
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Use safe_hasattr in dir2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test cases
Move safe_hasattr to utils/dir2
Fixes #4381 (and helps out pandas-dev/pandas#5182)