-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump minimum tornado version to 3.1.0 #4428
Conversation
in the notebook
|
||
def initialize(self, path, default_filename=None): | ||
if isinstance(path, basestring): | ||
path = [path] | ||
self.roots = tuple( | ||
self.root = self.roots = tuple( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the dual names? Should there be a comment explaining this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment added.
tornado needs self.root to be defined, but since we are storing a tuple I figured a plural name might be less confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be inclined to stick with tornado's name - I agree it's not perfect, but I think it's more confusing to have two slightly different names for the same thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, back to root.
Looks good. |
The no-hidden behavior of the files handler already requires this, but instead of raising, it just doesn't hide hidden files. Bumping the minimum version also allows much cleaner static file handler subclasses.
bump minimum tornado version to 3.1.0
bump minimum tornado version to 3.1.0
The no-hidden behavior of the files handler already requires this, but instead of raising on old tornado, hidden files are just served.
Bumping the minimum version also allows much cleaner static file handler subclasses.