bump minimum tornado version to 3.1.0 #4428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in the notebook
|
|
||
| def initialize(self, path, default_filename=None): | ||
| if isinstance(path, basestring): | ||
| path = [path] | ||
| self.roots = tuple( | ||
| self.root = self.roots = tuple( |
There was a problem hiding this comment.
Why the dual names? Should there be a comment explaining this?
There was a problem hiding this comment.
comment added.
tornado needs self.root to be defined, but since we are storing a tuple I figured a plural name might be less confusing.
There was a problem hiding this comment.
I'd be inclined to stick with tornado's name - I agree it's not perfect, but I think it's more confusing to have two slightly different names for the same thing.
|
Looks good. |
The no-hidden behavior of the files handler already requires this, but instead of raising, it just doesn't hide hidden files. Bumping the minimum version also allows much cleaner static file handler subclasses.
takluyver
added a commit
that referenced
this pull request
Oct 23, 2013
bump minimum tornado version to 3.1.0
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
bump minimum tornado version to 3.1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The no-hidden behavior of the files handler already requires this, but instead of raising on old tornado, hidden files are just served.
Bumping the minimum version also allows much cleaner static file handler subclasses.