relax ipconfig matching on Windows #4541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
looser match via regular expression, doesn't make English assumptions.
|
+1 |
|
Just FYI: windows XP only has "IP" without the version information. |
|
@JanSchulz thanks. It should fallback on gethostbyname, and thus still work when ipconfig parsing fails. |
|
but maybe the localization suggests that we should skip parsing on Windows altogether, and just let it use the slow way. |
|
Parsing |
|
Should we merge this ? |
minrk
added a commit
that referenced
this pull request
Nov 28, 2013
relax ipconfig matching on Windows
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
relax ipconfig matching on Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
looser match via regular expression, doesn't make English assumptions.
I don't know if Asian Windows has characters other than 'ipv4', but I would
doubt it.
closes #4538