-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add pickleutil.use_dill #4552
add pickleutil.use_dill #4552
Conversation
enables dill extended serialization support
I've also had issues with dill and testing. See uqfoundation/dill#16 |
I thought cPickle was the default on Py3, does this work than ? |
To expand: Possibly we should be setting dill itself as the pickle implementation? @mmckerns, any tips? |
To take advantage of dill, mpi4py abstracts the pickle import, so you can do this:
It requires the user to So you might be able to make a singleton somewhere with the module or with the dumps/loads functions. |
This singleton does already exist (well, in two places, so 'doubleton'?). I just need to change the |
set mod.pickle = dill
Will merge soon unless anyone wants to do further review. |
One could generalize this away from import dill
view.serialize_with(dill) But, given the small nature of this fix and the small number of fully functional serializers out there, this may be overly farsighted. |
+1 |
add pickleutil.use_dill
and
DirectView.use_dill
to call it locally and on all enginesexample notebook added. I tried to include tests, but something about the test environment causes problems with dill.
closes #4551