Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify encoding for reading notebook file. #4563

Merged
merged 2 commits into from
Nov 20, 2013
Merged

Conversation

takluyver
Copy link
Member

Closes #4562

@minrk
Copy link
Member

minrk commented Nov 20, 2013

There are a few more io.opens without encoding specified, might as well get them all.

@takluyver
Copy link
Member Author

Good point. I think I've got them all now, apart from the ones opening files in binary mode.

minrk added a commit that referenced this pull request Nov 20, 2013
Specify encoding for reading notebook file. and a few other calls to io.open with missing encoding
@minrk minrk merged commit 6e2b5ef into ipython:master Nov 20, 2013
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
Specify encoding for reading notebook file. and a few other calls to io.open with missing encoding
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nbconvert: Default encoding problem on OS X
2 participants