Modifies test_get_long_path_name_winr32() to allow for long path names in temp dir #4633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Travis failure looks unrelated. I think the code is fine, but I think the comment could be a bit clearer. Something like "tmpdir may already have a long path component, so ensure we include the long form of it". |
|
Looks good and test passes. Merging soon if no objections. |
|
+1 for merge... |
takluyver
added a commit
that referenced
this pull request
Dec 5, 2013
Modifies test_get_long_path_name_winr32() to allow for long path names in temp dir
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Modifies test_get_long_path_name_winr32() to allow for long path names in temp dir
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the remaining issues of #4629.