Don't check for wx in the test suite. #4641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An interaction between wx and threads was blocking certain Unix signals, causing an unrelated test to fail for me. We were only checking for wx to exclude the inputhookwx module from the test run. It contains no tests anyway, so we may as well just exclude it in all cases.
|
👍 |
|
travis failure on python3 was a "socket already in use" - restarted the job |
minrk
added a commit
that referenced
this pull request
Dec 4, 2013
Don't check for wx in the test suite. An interaction between wx and threads was blocking certain Unix signals, causing an unrelated test to fail for me. We were only checking for wx to exclude the inputhookwx module from the test run. It contains no tests anyway, so we may as well just exclude it in all cases.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Don't check for wx in the test suite. An interaction between wx and threads was blocking certain Unix signals, causing an unrelated test to fail for me. We were only checking for wx to exclude the inputhookwx module from the test run. It contains no tests anyway, so we may as well just exclude it in all cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An interaction between wx and threads was blocking certain Unix signals,
causing an unrelated test to fail for me.
We were only checking for wx to exclude the inputhookwx module from the
test run. It contains no tests anyway, so we may as well just exclude it
in all cases.