Remove magic for loading templates from module names #4724
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return 'tex' | ||
|
|
||
| def _template_file_default(self): | ||
| return 'article' | ||
|
|
||
| file_extension = Unicode( |
There was a problem hiding this comment.
Why you didn't delete this one? You have replace it (above) by _file_extension_default...
|
Except from the latex Exporter (which is using it for other things), all the exporters import Regardless of the comments I made above, I like the idea to remove the magic of loading templates... |
|
Both valid points, and I'll fix them. I'm going to open a new PR, though, because I accidentally committed on my master branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This specifies the template names in the exporter class, rather than getting them from the module names, which seemed a bit too magical.
Also, the latex templates got renamed from
latex/latex_foo.tplxtolatex/foo.tplx.At present, when specifying a template to use, you have to specify the full template name, e.g.
html_basic, not justbasic. We probably want to think more about this, but I wanted to put the code up for review before I flew home, and I've had too many glasses of scotch to think about it just now. ;-)