New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Nbconvert template loading magic #4727
Conversation
LGTM now... thanks!
Regarding this one... I don't have strong feelings about this issue but I think I am +0 for the full name: for people using the command line UI, I think that a more explicit name as |
I think it's a little unfortunate to add back the redundancy of |
I think it is ok to make the command line tool a little more complicated, On Fri, Dec 27, 2013 at 8:42 PM, Min RK notifications@github.com wrote:
|
This is a very interesting idea... |
Discussed this with Min, and we've put the HTML templates in a separate directory, like the latex templates already were. We can follow suit with any exporter that has more than one possible template. The exporter defines a We discussed making |
os.path.join("..", "templates", "latex"), config=True, | ||
help="Path where the template files are located.") | ||
def _default_template_path_default(self): | ||
return os.path.join("..", "templates", "latex") | ||
|
||
template_skeleton_path = Unicode( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same treatment for template_skeleton_path as default_template_path, probably
@minrk done & done. |
Weird, it works for me when I run |
And Travis is happy now. |
hooray! |
Remove Nbconvert template loading magic based on module name. A little more explicit now, plus a few traitlets cleaned up.
Remove Nbconvert template loading magic based on module name. A little more explicit now, plus a few traitlets cleaned up.
This specifies the template names in the exporter class, rather than getting them from the module names, which seemed a bit too magical. This continues #4724, which I made from my master branch by accident. The problems @damianavila noted there are fixed.
Also, the latex templates got renamed from
latex/latex_foo.tplx
tolatex/foo.tplx
.At present, when specifying a template to use, you have to specify the full template name, e.g.
html_basic
, not justbasic
. We may want to think more about this.