Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix selection widget construction with default values and labels. #5011

Closed
wants to merge 2 commits into from
Closed

Fix selection widget construction with default values and labels. #5011

wants to merge 2 commits into from

Conversation

jdfreder
Copy link
Member

@jdfreder jdfreder commented Feb 3, 2014

Fixes #4961

  • Don't validate labels and values until end of construction.
  • Added test to make sure a selection widget can be created with a default values and labels.

@jdfreder
Fixed selection widget constructor
7e8db8b 
It now will work with default labels and values provided by the user.
@jdfreder
Use a lock and...
5072f95 
, make sure len(labels)==len(values) by the end of construction.
@jdfreder
Copy link
Member Author

jdfreder commented Feb 3, 2014

Closed in favor of #5012

@jdfreder jdfreder closed this Feb 3, 2014
@jdfreder jdfreder deleted the widget-selection branch March 10, 2014 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
no action
Development

Successfully merging this pull request may close these issues.

Bug when constructing a selection widget with both values and labels
1 participant
@jdfreder