New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Widgets- add ability to pack and unpack arrays on JS side. #5023
Conversation
Ping @jasongrout for a review |
@jdfreder I know you said that testing this would be very tough, but is there any way to verify that it does the expected thing? |
Actually I don't think it would be bad at all. For some reason I was thinking of round trip tests, but all I need to do is test the function itself. |
OK, that would be great. If we can get a passing tests, I will merge :) On Tue, Feb 4, 2014 at 3:03 PM, Jonathan Frederic
Brian E. Granger |
Hmmm the tests pass locally.... I wonder what is going on |
They are still running... |
Woohoo they pass, @ellisonbg do you want to merge? |
Yep, great! |
Widgets- add ability to pack and unpack arrays on JS side.
ping @ChakriCherukuri, just to make sure you know this got merged into master. Thanks for bringing this issue up! |
(I didn't have time to review this, but glancing at the code, it looks great!) |
Widgets- add ability to pack and unpack arrays on JS side.
Fixes #5020