Move&rename JS tests

[jdfreder]

This PR will be used to try different JS test arrangements and eventually agree on one or keep the all-test-in-one-folder design we have now.

[ivanov]

you'll need to adjust the test_cases around line 184 of ipython/IPython/testing/iptestcontroller.py for the tests to start passing here

[ivanov]

That's also the place to add test sub-groups for js tests under js_test_group_names, the name of the group gets passed to JSController, let me know if you get stuck or want some help with this

[jdfreder]

Thanks Paul! I'll take a look-

[jdfreder]

@ivanov What do you think of the setup I just pushed?

Instead of /casperjs/test_cases/*.js, there is now

/casperjs/js/*.js
/casperjs/notebook/*.js
/casperjs/widgets/*.js

And two new test groups notebook and widgets. The folder names == test group name, but I use an explicit if/elif block in iptestcontroller to map the group names to folder names. Maybe it would be better if this mapping was implicit? Or is that too magical? See here - jdfreder@a61cd87#diff-f7b20eb6befe7d2ed0f2b0a61f1b9c36R185

[ivanov]

Sent you a PR to make the tests run- I think we should preserve 'js' to run all of the javascript tests, and rename the miscellaneous tests that are in the 'js' directory in your branch right now and call them 'jsmisc'

[ellisonbg]

@ivanov we talked and decided that there should be a separate test group for each of the different subdirs in static: base, auth, notebook, widgets, tree. Each of these will eventually have a ton of tests and should be runnable by itself. We were thinking that the tests groups would be named js-base, etc.

Would it be difficult to allow those to be run separately, but also have a global js group that runs them all?

[jdfreder]

Woops, thanks for the PR.

[ivanov]

having a js group that runs them all should be too hard, that's what I was just looking at...

[takluyver]

Since "js" is already short, does it make sense to simply do them as folders under js, so you'd run e.g. iptest js/base? That also provides an obvious way to drill down further to individual files.

[ellisonbg]

Sure, I think that syntax would be a nice way of doing it. I would love to have an easy way of running individual tests in subdirs.

[ivanov]

@ellisonbg one can, just not from the way iptest uses it right now. Let me see if I can add that as well.
In the meantime, if you run casperjs directly, you can do this casperjs test --includes=util.js test/file/name.js so long as you have a notebook server running on 8888, otherwise, you specify --port as well

[ivanov]

I sent jdfreder#13 which supports running individual js tests, as well as treating all subdirectories of casperjs as a separate test group

[ivanov]

Ok, I've updated the jdfreder#13 PR I sent @jdfreder

• iptest js-subfolder will run the tests in that subfolder, and the subfolders aren't hard-coded.
• iptest js-notebook/execute_code.js will run only that test file (like @ellisonbg wanted)
• iptest js runs all subdirectories in casperjs (each with its own server, so the groups can be run in parallel)
• the js- prefix is just one variable, so if we like js/subfolder style better, we can use that easily instead.

[ivanov]

In my PR to @jdfreder I changed the prefix to js/ so now you do iptest js/notebook/execute_code.js, as per suggestion from @takluyver

[ellisonbg]

I like this short form better, thanks @ivanov

On Fri, Feb 7, 2014 at 4:26 PM, Paul Ivanov notifications@github.comwrote:

In my PR to @jdfreder https://github.com/jdfreder I changed the prefix
to js/ so now you do iptest js/notebook/execute_code.js

Reply to this email directly or view it on GitHubhttps://github.com//pull/5053#issuecomment-34521797
.

Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com

[ellisonbg]

Hmm, getting a traceback:

IPython test group: js
Traceback (most recent call last):
  File "/Users/bgranger/Documents/Computing/IPython/code/ipython/IPython/testing/iptestcontroller.py", line 271, in do_run
    controller.launch()
  File "/Users/bgranger/Documents/Computing/IPython/code/ipython/IPython/testing/iptestcontroller.py", line 184, in launch
    test_cases = os.path.join(test_dir, self.section.split('-'))
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/posixpath.py", line 75, in join
    if b.startswith('/'):
AttributeError: 'list' object has no attribute 'startswith'

Also, I am not thrilled about the double nesting tests/casperjs/js/foo. Could we figure out a way to do just tests/js/foo. It would just mean putting utils.js in tests/js, but that should be fine as it doesn't actually run any tests so will just be skipped (we can still include it).

[ellisonbg]

But let's get this done ASAP so other test work can continue.

[jdfreder]

It wont let me merge @ivanov 's PR because it hasn't been rebased with the changes to my branch. I'll check it out and merge it manually since he is probably offline right now.

[jdfreder]

Since the changes I had made were similar to @ivanov 's but not as progressed , I just force pushed his branch here.

[jdfreder]

I moved the tests into folders that map 1-to-1 one with the folders in static (as discussed in person with @ellisonbg ). Also, I remove tests\casperjs...

The structure follows:

• tests\util.js
• tests\base*.js
• tests\notebook*.js
• tests\services*.js
• tests\tree*.js <- (I put the dashboard tests in here, is that right @ellisonbg ?)
• tests\widgets*.js

The thought is that in another PR the main widgets folder will get moved out of the notebook/ folder in static (since the widgets don't event require any IPython specific elements to work).

[ellisonbg]

There is an actual test failure on Travis. Something about js/__pycache__...

[jdfreder]

Just hardcoded it in to be ignored... I guess we wait on Travis now.

[ellisonbg]

Will this fail on Windows (/)?

[ellisonbg]

The README.md in the tests folder should be updated with current information about how to run the JS tests.

There are a couple of places where we hardcoded the path separator /. Let's test this on Windows to make sure it works. there is one question though: obviously internally we should use os.sep instead of '/'. But what about the command line API: should it be:

• iptest js/base for all platforms
• iptest js/base for Unix and iptest js\base for Windows.

[ivanov]

@takluyver and I verified that the glob stuff with a / works on
windows before putting that in. The js/ prefix is only used for
the command line interface, and is cut out before using the rest
as a path,, so that will work as well.

[ellisonbg]

Nice, thanks @ivanov ! So I guess the only thing to fix then is the README.md.

[ellisonbg]

I will rewrite the README.md in a separate PR. Everything else looks ready to go, merging.