Fix incorrect Patch logic in widget code

[jdfreder]

This does not work in master

this.model.set('x', x);
this.model.set('y', y);
this.model.set('z', z);
this.touch();

instead one has to write

this.model.set('x', x);
this.touch();
this.model.set('y', y);
this.touch();
this.model.set('z', z);
this.touch();

or

this.model.set({'x': x, 'y': y, 'z': z});
this.touch();

because the attr diff is only maintained for the last set operation. This patch fixes this so the first method can be used.

[jdfreder]

@ellisonbg

• This fix is working and ready for you to test with your custom widget.
• I've also added a new test that confirms that the problem is fixed.

[jdfreder]

@ellisonbg I successfully made the changes we talked about in person (9140177), a running buffer of the diff is maintained by us now.

[ellisonbg]

@jdfreder thanks I will test this later.

is there a test to verify this works and that we don't ever send a full
update in these situations?

On Fri, Feb 7, 2014 at 2:24 PM, Jonathan Frederic
notifications@github.comwrote:

@ellisonbg https://github.com/ellisonbg I successfully made the changes
we talked about in person (91401779140177),
a running buffer of the diff is maintained by us now.

Reply to this email directly or view it on GitHubhttps://github.com//pull/5059#issuecomment-34514172
.

Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com

[jasongrout]

'operation'

[jdfreder]

Thanks!

[jdfreder]

is there a test to verify this works and that we don't ever send a full
update in these situations?

The test doesn't check to make sure that a full state isn't sent, should I add that test?

The test only makes sure that set,set,set,touch works.

[ellisonbg]

If it is not too much trouble, it would be great to have a test that checks to make sure we don't send full states. That could really kill a widget with a large model.

[jdfreder]

Test added! Found a bug in the process 😛

[jdfreder]

• and fixed

[ellisonbg]

Nice, I will wait for the tests and then merge.