Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reorganize who knows what about paths #5116

Merged
merged 4 commits into from
Feb 22, 2014
Merged

reorganize who knows what about paths #5116

merged 4 commits into from
Feb 22, 2014

Commits on Feb 21, 2014

  1. reorganize who knows what about paths 

    - add NotebookApp.notebook_dir
- add KernelManager.root_dir
- remove NotebookManager.notebook_dir, move to FileNBM.notebook_dir

Default value for KM.root_dir and fNBM.notebook_dir is NotebookApp.notebook_dir, but they can be configured separately.

SessionManager passes the API path to KernelManager,
which is responsible for turning it into the kernel's cwd.
    @minrk
    minrk committed Feb 21, 2014
    Configuration menu
    Copy the full SHA
    f97d9dd View commit details
    Browse the repository at this point in the history

  2. use NotebookManager APIs in nbconvert handler

    @minrk
    minrk committed Feb 21, 2014
    Configuration menu
    Copy the full SHA
    8c161a0 View commit details
    Browse the repository at this point in the history

  3. use config instead of App.instance to propagate notebook_dir 

    Should behave more logically (I hope).
    @minrk
    minrk committed Feb 21, 2014
    Configuration menu
    Copy the full SHA
    8a008e3 View commit details
    Browse the repository at this point in the history

  4. don't create notebook_dir if it doesn't exist

    @minrk
    minrk committed Feb 21, 2014
    Configuration menu
    Copy the full SHA
    2a2324a View commit details
    Browse the repository at this point in the history