get _ipython_display_ method safely #5229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool. This PR is working for me. |
| @@ -64,7 +64,9 @@ def _valid_formatter(f): | |||
| - unbound methods NO | |||
| - callable with zero args OK | |||
| """ | |||
| if isinstance(f, type(str.find)): | |||
| if f is None: | |||
| return | |||
There was a problem hiding this comment.
return False, to keep the API consistent
There was a problem hiding this comment.
oops, that's because I moved the clause from the new function below. Good catch, fixed.
|
Other than that, looks good. |
use the same method we use for `_repr_foo_`
|
Yep, LGTM too... |
takluyver
added a commit
that referenced
this pull request
Feb 27, 2014
get _ipython_display_ method safely
|
Hi, this only works if the returned object is not callable. Is there a way to tell IPython to avoid trying to use that method at all (or on some classes/objects)? |
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
get _ipython_display_ method safely
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use the same method we use for
_repr_foo_closes #5227