Don't allow edit mode up arrow to continue past index == 0

[jdfreder]

closes #5259

[ellisonbg]

The code looks good and I have confirmed the fix. Merging.

[minrk]

This shouldn't have been merged, there are more serious issues at work that should be addressed.

[ellisonbg]

I know we may have other bugs to track down, but this does fix the issue.
Are you saying it doesn't fix the issue? Or that the fix is suboptimal? Can
you clarify what those other issues are?

On Mon, Mar 3, 2014 at 11:38 AM, Min RK notifications@github.com wrote:

This shouldn't have been merged, there are more serious issues at work
that should be addressed.

Reply to this email directly or view it on GitHubhttps://github.com//pull/5261#issuecomment-36549917
.

Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com

[ellisonbg]

Looking at this further, I do see an issue with how we call command_mode for the up/down keyboard shortcuts without calling focus_cell_. Working on a fix for that. Is this the issue you were referring to?

[minrk]

We were looking over this fix and the various other similar bugs still in master, and this seemed like treating a symptom rather than addressing the root cause. Based on the behavior, it seems like there is a more severe underlying issue, and little patches as individual symptoms are noticed are not helping address it.

[ellisonbg]

We think the other issues showing up in master are from situations where
people haven't done git submodule update. But there were deeper issue
related to this one that #5268 addresses.

On Mon, Mar 3, 2014 at 3:04 PM, Min RK notifications@github.com wrote:

We were looking over this fix and the various other similar bugs still in
master, and this seemed like treating a symptom rather than addressing the
root cause. Based on the behavior, it seems like there is a more severe
underlying issue, and little patches as individual symptoms are noticed are
not helping address it.

Reply to this email directly or view it on GitHubhttps://github.com//pull/5261#issuecomment-36572346
.

Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com

[minrk]

We think the other issues showing up in master are from situations where
people haven't done git submodule update. But there were deeper issue
related to this one that #5268 addresses.

We were seeing issues here in master, with clean submodules. Perhaps #5268 is the fix.

[ellisonbg]

I would open separate issues for them. It helps us to track them - even if
#5268 fixes them, there could be other things we need to fix that the bugs
help uncover.

On Mon, Mar 3, 2014 at 3:57 PM, Min RK notifications@github.com wrote:

We think the other issues showing up in master are from situations where
people haven't done git submodule update. But there were deeper issue
related to this one that #5268https://github.com/ipython/ipython/pull/5268addresses.

We were seeing issues here in master, with clean submodules. Perhaps #5268https://github.com/ipython/ipython/pull/5268is the fix.

Reply to this email directly or view it on GitHubhttps://github.com//pull/5261#issuecomment-36576617
.

Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com