Some gardening on iptest result reporting #5326
Conversation
|
Are we planting 🍆, 🍅 or 🌽? One minor thing: right now it doesn't actually print the directory name: |
| @@ -208,6 +216,10 @@ def _init_server(self): | |||
| self.server.start() | |||
| self.server_port = q.get() | |||
|
|
|||
| def dump_failure(self): | |||
| print("Ran tests with notebook directory %r" % self.nbdir) | |||
|
Do we need to modify something in the |
|
Fixed printing the directory name. I'm not exactly sure what to do for the |
Add a setup() method to be called when we know we're going to use a test group, for creating temporary dirs etc., and a print_extra_info() method to display extra information.
|
OK, this got a little more complicated. Instead of However, that method may need info such as the locations of temporary directories. In fact, that's the motivation for adding it in the first place. Those can't be defined in launch(), because when we're not running in parallel, it's called before launch(). And they shouldn't be defined in |
|
There are two more "IPython test group" instances that can be shortened to "Test group". |
|
While we are at it in this file, the command line help for the |
|
I like the overall design of the refactoring though. I think this is mostly ready to do after a few minor changes. |
|
Well, the easiest use of |
|
Ahh, more complicated (and nicer) than I though. Even more reason to clarify the help string. Thnx |
|
OK, I've cleaned those things up. |
|
Looks good, merging. |
Some gardening on iptest result reporting
Some gardening on iptest result reporting
My nice concise output when running
iptest -j6was being messed up by some lines like "Running js/tree tests in directory: '/tmp/tmp994_q5'" that had snuck in. There wasn't a good way for the test process to add potentially useful information on failure without it showing up in the concise view on success. This adds that: aTestController.dump_failure()method which prints stdout from the test process.JSControlleroverrides this to add the notebook directory.While looking at this, @ivanov pointed out that "IPython test group" was unnecessary, so I shortened it to "Test group".