allow async output on the most recent request #5668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keeps track of the most recent request, so async output is still allowed
|
An alternative to this would be forcing the callers of the kernel API to do the cleanup (cells, widgets), so that the number of callbacks is limited to the number of existing cells and widgets. We would have to make sure we clear previous callbacks whenever new requests are sent, as well as whenever cells / widgets are removed, and be careful about duplicating cells. |
minrk
added a commit
that referenced
this pull request
May 6, 2014
allow async output on the most recent request
|
I tested current master and I can confirm that this fixes the problem of missing output from interactive matplotlib figures, thanks. |
takluyver
added a commit
that referenced
this pull request
May 7, 2014
Keeps track of the most recent request, so async output is still allowed closes #5407
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
allow async output on the most recent request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeps track of the most recent request, so async output is still allowed
closes #5407