support ssh multiplexer in tunnels #4717 #5886
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The recent change in commit 9db9742 means that code in external/ssh/ is no longer used, so perhaps this pull request should have been upstream to pyzmq? |
|
Yes, please do make the same PR upstream to pyzmq. |
|
submitted upstream zeromq/pyzmq#551 |
|
zeromq/pyzmq#551 is merged, closing here in favor of #5927. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit 3967cb5 forced multiplexing off with "-S none", overriding the user's ssh configuration, to work around a bug in openssh (#4717, #4720)
This patch uses the multiplex connection if one is available, while avoiding the problem with the "-f" bug.
Reason: our university's cluster blocks you for half an hour if you make more than 3 connections to
port 22 within one minute. This makes IPython unusable via ssh at the moment. I think this patch resolves it.
Have done some minimal testing, with/without mux and with/without public key auth.