add pickleutil.PICKLE_PROTOCOL #6029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of hardcoding `-1`. default to DEFAULT_PROTOCOL if defined (Python 3.4), and HIGHEST_PROTOCOL otherwise. Matches dill behavior
|
+1 |
| @@ -28,6 +28,11 @@ | |||
| from types import ClassType | |||
| class_type = (type, ClassType) | |||
|
|
|||
| try: | |||
There was a problem hiding this comment.
Do we want a comment explaining that DEFAULT_PROTOCOL is only defined in Python 3?
takluyver
added a commit
that referenced
this pull request
Jun 26, 2014
add pickleutil.PICKLE_PROTOCOL
minrk
added a commit
that referenced
this pull request
Jul 7, 2014
instead of hardcoding `-1`. default to DEFAULT_PROTOCOL if defined (Python 3.4), and HIGHEST_PROTOCOL otherwise. ...
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
add pickleutil.PICKLE_PROTOCOL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of hardcoding
-1.default to DEFAULT_PROTOCOL if defined (Python 3.4), and HIGHEST_PROTOCOL
otherwise.
Matches dill behavior
closes #5998