Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added PageUp and PageDown functionality for the notebook #8172

Closed
wants to merge 1 commit into from

Conversation

AtrSykes
Copy link

PageUp and PageDown now move between cells rather than stay confined
to their cell

PageUp and PageDown now move between cells rather than stay confined
to their cell
@Carreau
Copy link
Member

Carreau commented Mar 27, 2015

Hum, the behavior seem weird to me, I would expect page-up to:

  • bring me to top of cell
  • if already at top of cell move to last line of previous one.

I'm not sure why it does not do that, and if it's expected behavior.

@takluyver
Copy link
Member

I think I would have expected it to jump directly to the previous cell (or next, for page down), regardless of where I was in the cell.

@Carreau
Copy link
Member

Carreau commented Mar 27, 2015

Then that's not either what it does. If the cell is more than one screen, it jumps in current CM by one screen unit.

@takluyver
Copy link
Member

I guess that could be useful if you had particularly long cells.

@ellisonbg
Copy link
Member

Page up and page down keystrokes should do the same thing as spacebar and shift-spacebar, which use our scroll manager to scroll the notebook div.

@Carreau
Copy link
Member

Carreau commented Mar 29, 2015

No because here we speak of edit mode. PageUp and Down should not insert
space.

On Sun, Mar 29, 2015 at 11:36 AM, Brian E. Granger <notifications@github.com

wrote:

Page up and page down keystrokes should do the same thing as spacebar and
shift-spacebar, which use our scroll manager to scroll the notebook div.


Reply to this email directly or view it on GitHub
#8172 (comment).

@ellisonbg
Copy link
Member

Ahh, sorry I missed that. If this only applies to edit mode, then I would think that the notebook div would:

  1. ??? - if the current cell is smaller that one scroll screen.
  2. Move one CM scroll unit if that exists in the current cell in that desired scroll direction.

Because of the awkwardness of decided what to do in the 1 case, and the complexity of the logic required for 2 I am not sure this makes sense. I am probably -0.5 on this.

@Carreau
Copy link
Member

Carreau commented Jun 12, 2015

This does not merge cleany anymore, and have lost activity for almost 3 month.
Feel free to reopen if you plan to work on it again.

@Carreau Carreau closed this Jun 12, 2015
@minrk minrk modified the milestone: no action Aug 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants