add import hook to shims #8186
Merged
add import hook to shims #8186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @takluyver I also removed the reimplementation of import_item, since it appears that using import_item works properly, now. Not sure what it was that caused that to fail, but it doesn't seem to matter anymore. |
This ensures that submodule imports return the real target module, not a clone that will confuse `is` and `isinstance` checks.
The problem described in the comment does not appear to exist anymore
|
Seems sensible, tests passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that submodule imports return the real target module, not a clone that will confuse
isandisinstancechecks.