Further split some client/kernel functionality #8204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- general read/write/mixin utils in client.connect - IPython-application specific in kernel.connect Still some changes to make on the Jupyter side once we have base JupyterApp
|
There seems to be quite a bit more deleted than added here - did you duplicate some code while splitting client & kernel, and this is paring it back? |
|
Yup, there were two unmodified copies of connect.py. I removed client bits from the one in kernel, and kernel bits from the one in client. |
takluyver
added a commit
that referenced
this pull request
Apr 1, 2015
Further split some client/kernel functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connect.py had some kernel-specific functions and some general Juyter functions
The consoleapp base class is also moved to jupyter_client