Split IPython specific functions out of utils.path #8214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takluyver
force-pushed
the
split-utils-path
branch
from
e70b90e
to
58803c7
Compare
|
+1 |
| @@ -0,0 +1,246 @@ | |||
| from contextlib import contextmanager | |||
There was a problem hiding this comment.
I assume this isn't meant to be in magics
| # will raise ProfileDirError if no such profile | ||
| raise IOError("Profile %r not found") | ||
| return filefind(filename, ['.', pd.security_dir]) | ||
| warn("get_security_file has moved to the IPython.paths module") |
There was a problem hiding this comment.
get_security_file is going to leave IPython entirely, since it's a Jupyter function.
There was a problem hiding this comment.
I found we were only using this in one example, and find_connection_file, which is already in jupyter_client, works as well for that, so I have removed this function entirely.
minrk
added a commit
that referenced
this pull request
Apr 2, 2015
Split IPython specific functions out of utils.path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions like
get_ipython_dir()are moved to a newIPython.pathsmodule. This should facilitate moving the remainder of utils.path into genutils. Wrappers are left in utils.path which will still work, but issue a deprecation warning on call.While doing this, I noticed that the code to check for pre-0.11 config files and warn about them is still in place. I think that has served its purpose and can be retired now.