Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use isinstance #8778

Merged
merged 1 commit into from Aug 29, 2015
Merged

Use isinstance #8778

merged 1 commit into from Aug 29, 2015
+2 −2

Conversation

SylvainCorlay
Copy link
Member

I don't think that magic.py should need to import MetaHasTraits.

@ssanderson
Copy link
Member

👍 this seems straightforwardly more correct to me.

@minrk minrk added this to the 4.1 milestone Aug 29, 2015
minrk added a commit that referenced this pull request Aug 29, 2015
@minrk
Merge pull request #8778 from SylvainCorlay/Meta
3ac9be5 
Use isinstance to check for types
@minrk minrk merged commit 3ac9be5 into ipython:master Aug 29, 2015
@SylvainCorlay SylvainCorlay deleted the Meta branch January 10, 2016 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SylvainCorlay @ssanderson @minrk