Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x shrink image #8856

Closed
wants to merge 9 commits into from
Closed

3.x shrink image #8856

wants to merge 9 commits into from

Conversation

funkyfuture
Copy link

i admit, i may freaked out a little.

these commits reduce the image's layer's size from ~575MB to ~502MB and from 25 layers to 9.

i did no research what the removal of software could break in depending images. the iptests are passing.

pick what you want. shall i open a similar pr against the master-branch?

.mailmap
.travis.yml
IPython/html/static/components/.git
IPython/html/static/components/.gitignore
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are certainly a good idea to dockerignore.

@rgbkrk
Copy link
Member

rgbkrk commented Oct 2, 2015

Seems fine with me for the 3.x series.

@rgbkrk
Copy link
Member

rgbkrk commented Oct 2, 2015

pick what you want. shall i open a similar pr against the master-branch?

If you look in master, the Dockerfile is just an "echo" telling users to use jupyter/notebook instead. I wouldn't go after PRs against master.

@minrk
Copy link
Member

minrk commented Oct 2, 2015

I'm not sure how much more we should be working on this, since there will not be any more 3.x releases unless we find security problems. @funkyfuture can you try to make your PRs against the jupyter/notebook repo or jupyter/docker-stacks instead?

@funkyfuture
Copy link
Author

i'm still confused about that ipython-/jupyter-images.
i am using the ipython/notebook-image. am i actually supposed to use that?

what should i use if i wanted to use IPython w/o the notebook?

@minrk
Copy link
Member

minrk commented Oct 2, 2015

@funkyfuture if you want a docker image without the notebook, it probably doesn't make sense to use IPython as a base image, since installing IPython is just pip install ipython, and there are no services to run. Starting with 4.0, the ipython/ipythonimage is deprecated, and we don't plan to maintain a base docker image for IPython anymore. If you want the notebook, you can use jupyter/notebook or one of the docker-stacks images.

@rgbkrk
Copy link
Member

rgbkrk commented Oct 2, 2015

It does seem reasonable that people would want an ipython console docker image, I end up using notebook images for that all the time. As for us maintaining it, we wouldn't want it pinned to the latest whims on master. Seems more like something to contribute to the docker-library image suite (ipython:3, ipython:2, notebook, ... etc.)

@minrk
Copy link
Member

minrk commented Oct 3, 2015

It does seem reasonable that people would want an ipython console docker image

Does it, though? What would an IPython base image be useful for? I think base images only make sense if:

  1. it provides a complete, working environment or service, or
  2. it's hard to install

Since base images are a once-ever choice, and changing the base is a nightmare, I can't see any use for an IPython base image without the notebook.

we wouldn't want it pinned to the latest whims on master

ipython:3.x is already defined as a notebook server, and since 4.x is current stable, there are no planned releases of 3.x in the future, so for an IPython base image that's not a notebook server, it should start with 4.x at the earliest.

An IPython base image would be three lines:

FROM debian:jessie # already making a potentially unhelpful choice
apt-get -y update && apt-get -y install python3-pip
pip3 install ipython

and if it's not a base image and Python is already working, getting IPython is one line, and doesn't tie you down by making a bunch of assumptions. Since Dockerfiles are not composable, base images that aren't complete environments are hardly useful, since you can only pick one. If it were more akin to ansible recipes, I'd be all for IPython

@rgbkrk
Copy link
Member

rgbkrk commented Oct 3, 2015

To clarify, I'm saying that base image would belong in https://github.com/docker-library/official-images as ipython.

@funkyfuture
Copy link
Author

thanks for the feedback, I'll open a similar pr for jupyter/notebook.

as a casual IPython user, a note in the image description guiding me to jupyter/notebook would have been useful.

just throwing some cents here:

An IPython base image would be three lines:

actually two are possible:

FROM python
RUN pip install ipython

Since Dockerfiles are not composable

i think nested builds are planned for Docker.

@funkyfuture funkyfuture closed this Oct 5, 2015
@minrk
Copy link
Member

minrk commented Oct 5, 2015

@funkyfuture thanks, I updated the image description to point to jupyter/notebook. The current Dockerfile in this repo does nothing but point to jupyter/notebook already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants