Set literal #8959
Merged
Set literal #8959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -115,8 +115,8 @@ def test_sets(): | |||
| """ | |||
| Test that set and frozenset use Python 3 formatting. | |||
| """ | |||
| objects = [set(), frozenset(), set([1]), frozenset([1]), set([1, 2]), | |||
There was a problem hiding this comment.
so here the non literal seem to be on purpose: Test that set and frozenset use Python 3 formatting
Otherwise, we would have tested the round-tripping of the string representation through eval.
|
In general we try to avoid huge cleanup PRs, this one is not too big, so it's fine. |
|
@Carreau Fixed |
|
@Carreau Are you still interested or should it be closed? |
|
Yes, sorry. Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.