Default profile #964
Merged
Default profile #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also add missing shell.profile_dir in ipkernel closes ipythongh-939
|
Now also includes Min's fix so starting the qtconsole and specifying a different profile works properly (#939). |
|
Looks good to me, thanks! |
| @@ -80,7 +80,7 @@ def test_startup_py(): | |||
| # write simple test file, to check that the startup file was run | |||
| fname = os.path.join(TMP_TEST_DIR, 'test.py') | |||
| with open(fname, 'w') as f: | |||
| f.write('print zzz\n') | |||
| f.write(py3compat.doctest_refactor_print('print zzz\n')) | |||
There was a problem hiding this comment.
@takluyver, when you get a chance, do you want to toss together a writeup of the py3compat stuff? The unicode_to_str, etc. is clear enough, but some of these would warrant a good doc, so we don't make you keep fixing our tests, etc. for py3 quite so often.
There was a problem hiding this comment.
Sure. I'll put something together on the wiki.
There was a problem hiding this comment.
There was a problem hiding this comment.
Thanks! this branch has been merged.
minrk
added a commit
that referenced
this pull request
Nov 2, 2011
Python 3 being fully supported, it is no longer relegated to a special profile. Users of both Python 3 and Python 2 will now get the same default profile (history, config, etc.) in each. Closes gh-939, fixing the profile directory and magic in the IPython kernel.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Python 3 being fully supported, it is no longer relegated to a special profile. Users of both Python 3 and Python 2 will now get the same default profile (history, config, etc.) in each. Closes ipythongh-939, fixing the profile directory and magic in the IPython kernel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, this makes the default profile the same for Python 2 and 3.
Also includes a fix for a new test that was failing on Python 3.