Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

observe should allow any iterable containers. #215

Closed
Carreau opened this issue May 16, 2016 · 0 comments · Fixed by #253
Closed

observe should allow any iterable containers. #215

Carreau opened this issue May 16, 2016 · 0 comments · Fixed by #253
Milestone

Comments

@Carreau
Copy link
Member

Carreau commented May 16, 2016

Not just list, and tuple, thinks like set... should work.

More generally you should fix parse_notifier_name.

And technically it should allow any container that implement __contains__ I guess. And parse_notifier_name should not blindly return nothing (ie None) if the type of argument is not one of the accepted argument. It shoudl raise a meaningful error.

@Carreau Carreau changed the title Observer should allow any iterable containers. observe should allow any iterable containers. May 16, 2016
@Carreau Carreau modified the milestone: 4.3 May 17, 2016
@minrk minrk closed this as completed in #253 Aug 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant