Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better errors, type checking in event handlers #253

Merged
merged 2 commits into from
Aug 4, 2016

Conversation

minrk
Copy link
Member

@minrk minrk commented Jul 1, 2016

minrk added 2 commits July 1, 2016 13:06
rather than checking specifically for list, tuple
raise TypeError immediately if names aren't strings
@rmorshea
Copy link
Contributor

rmorshea commented Jul 1, 2016

If we move forward with #230 this will get covered, by parse_notifier_name in TraitEventHandlers, and a similar change to parse_notifier_name that I happened to include - I hadn't tagged to close #221 which is why this might not have shown up.

@minrk minrk added this to the 4.3 milestone Aug 4, 2016
@minrk
Copy link
Member Author

minrk commented Aug 4, 2016

@rmorshea I’m going to merge this one since it’s small and addresses the problem, so we can get 4.3 out the door. Then we can move forward with #230 for 5.0.

@minrk minrk merged commit 838606a into ipython:master Aug 4, 2016
@minrk minrk deleted the observe-iterable branch August 4, 2016 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants