Refactor Application and Config #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tony-iqlusion
commented
May 22, 2019
| @@ -55,14 +55,31 @@ dependencies = [ | |||
| "memchr 2.2.0 (registry+https://github.com/rust-lang/crates.io-index)", | |||
| ] | |||
|
|
|||
| [[package]] | |||
| name = "argon2rs" | |||
There was a problem hiding this comment.
This appears to be added due to the term crate, whose author is looking for a new maintainer.
In a follow-up PR I'll take a look at switching to termcolor which is both maintained and has significantly fewer dependencies (it actually appears to have no dependencies when using it on non-Windows platforms).
tony-iqlusion
commented
May 22, 2019
| ] | ||
|
|
||
| [[package]] | ||
| name = "bitflags" | ||
| version = "1.0.4" | ||
| source = "registry+https://github.com/rust-lang/crates.io-index" | ||
|
|
||
| [[package]] | ||
| name = "blake2-rfc" |
There was a problem hiding this comment.
Also a transitive dependency of the term crate.
tarcieri
force-pushed
the
application-and-config-refactor
branch
4 times, most recently
from
bf4de24
to
0698906
Compare
This change makes Application-types the global state, as opposed to the configuration. The configuration is now owned by the application. This brings Abscissa a bit closer to an Entity-Component-System, where the Application is the owner of all state, including the components, and is thus able to obtain mutable references to its internal state. Additionally this includes a fairly large refactor of application path handing, adding a `Paths` associated type to `Application`, and computing all paths in advance upon application startup.
tarcieri
force-pushed
the
application-and-config-refactor
branch
from
0698906
to
9bd38d4
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes Application-types the global state, as opposed to the configuration. The configuration is now owned by the application.
This brings Abscissa a bit closer to an Entity-Component-System, where the Application is the owner of all state, including the components, and is thus able to obtain mutable references to its internal state.
Additionally this includes a fairly large refactor of application path handing, adding a
Pathsassociated type toApplication, and computing all paths in advance upon application startup.This also includes a number of dependency updates including bumping
zeroizeto 0.8 andcanonical-pathto 2.0. It also seems we've accumulated a number of unintended transitive dependencies... I've left some notes on the Cargo.lock and will look at how to remove them in follow-up PRs.