core: remove generational-arena
#424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
core/remove-generational-arena
branch
2 times, most recently
from
23a383c
to
6cb8ba0
Compare
The original idea behind using `generational-arena` for component storage was to support some kind of component reloading. However, components aren't anywhere close to finished, and in the meantime using something like `generational-arena` for this purpose is a premature "optimization" which makes refactoring components more difficult and introduces an unnecessary dependency. This commit replaces `generational-arena` with a `Vec`, which is good enough for now. This is simple enough to swap out that the API is pretty much unchanged.
tarcieri
force-pushed
the
core/remove-generational-arena
branch
from
6cb8ba0
to
c831f86
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original idea behind using
generational-arenafor component storage was to support some kind of component reloading.However, components aren't anywhere close to finished, and in the meantime using something like
generational-arenafor this purpose is a premature "optimization" which makes refactoring components more difficult and introduces an unnecessary dependency.This commit replaces
generational-arenawith aVec, which is good enough for now.This is simple enough to swap out that the API is pretty much unchanged.