core: fine-grained application state locking #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the `RwLock` on application state (previously located in `AppCell`), replacing it with a fine-grained locking strategy: - Makes the `Application` type immutable with various interior mutability strategies - Uses `arc-swap` to handle updatable `Config` storage, as mediated through a new `CfgCell` wrapper - Makes the `application::State` struct opaque with `RwLock` access to inner fields mediated by method-based accessors - Adds type aliases for state accessors to make changing the strategy simpler in the future
tarcieri
force-pushed
the
core/fine-grained-application-state-locking
branch
from
a070d70
to
a7bf6db
Compare
tony-iqlusion
deleted the
core/fine-grained-application-state-locking
branch
This was referenced Oct 6, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the
RwLockon application state (previously located inAppCell), replacing it with a fine-grained locking strategy:Applicationtype immutable with various interior mutability strategiesarc-swapto handle updatableConfigstorage, as mediated through a newCfgCellwrapperapplication::Statestruct opaque withRwLockaccess to inner fields mediated by method-based accessors